feat: Wire in open and close times for hacker POST #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: hasOwnProperty vulnerability (see https://eslint.org/docs/rules/no-prototype-builtins) * feat: _id value to all route objects, starting at 100 and moving upwards. Add warning at top of file to maintain naming standard. * feat: update role.constant.js to use the new _id attribute so that ids are deterministic between two runs of npm run seed. * feat: update architecture documentation
* feat: Add HACKER_UPDATE_BATCH success message * feat: Add promise.allsettled so that we can wait for many promises to complete * feat: Add findByHackerId function to Account * feat: Add updatedHackerBatch controller function, generalize validation function, fix router * fix: resolve bug where requests hang when response is null * feat: set route apiVersion number to be 3.0.0 * feat: create parseAcceptBatch Co-authored-by: Pierre Theo Klein <pierre.klein@mail.mcgill.ca>
loreina
reviewed
Jul 31, 2020
Member
loreina
left a comment
loreina
left a comment
There was a problem hiding this comment.
sweeeeeeeet stuff 🎉 🎉 🎉
nit: should probably stay consistent between "application" and "registration"
loreina
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tickets:
#661
List of changes:
Type of change
Please delete options that are not relevant.
How has this been tested?
Questions for code reviewers?
Checklist: