feat: add previous hackathons field to application #670

Tony9984 · 2020-10-16T22:58:47Z

Tickets:

HCK-

List of changes:

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Add "previousHackathons" field to model, updated application validation, tests, route documentation, etc. to reflect changes

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
New release
This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
Listed change(s) in the Changelog
I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
I have made corresponding changes to the documentation
Any dependent changes have been merged and published in downstream modules

logan-r

Looks good! Haven't run locally tho, can you confirm that:

a) Tests pass
b) You can POST localhost:3000/api/hacker with

{
    "accountId": "[AN EXISTING ACCOUNT ID]",
    "application":{
        "general":{
            "school": "McGill University",
            "degree": "Undergraduate",
            "fieldOfStudy": ["Computer Science"],
            "graduationYear": 2021,
            "jobInterest":"Internship",
            "URL":{
                "resume":"resumes/1543458163426-5bff4d736f86be0a41badb91",
                "github":"https://github.com/abcd",
                "dropler":"https://dribbble.com/abcd",
                "personal":"https://www.hi.com/",
                "linkedIn":"https://linkedin.com/in/abcd",
                "other":"https://github.com/hackmcgill/hackerAPI/issues/168"
            }
        },
        "shortAnswer": {
            "skills":["Javascript","Typescript"],
            "question1": "I love McHacks",
            "question2":"Pls accept me",
            "comments":"hi!",
            "previousHackathons": "0"
        },
        "other": {
            "gender": "male",
            "ethnicity": ["Asian or Pacific Islander"],
            "privacyPolicy": true,
            "codeOfConduct": true
        },
        "accommodation": {
            "travel": 0,
            "shirtSize": "S"
        }
    }
}

and it shows up in mongo

c) POSTing localhost:3000/api/hacker with

{
    "accountId": "[AN EXISTING ACCOUNT ID]",
    "application":{
        "general":{
            "school": "McGill University",
            "degree": "Undergraduate",
            "fieldOfStudy": ["Computer Science"],
            "graduationYear": 2021,
            "jobInterest":"Internship",
            "URL":{
                "resume":"resumes/1543458163426-5bff4d736f86be0a41badb91",
                "github":"https://github.com/abcd",
                "dropler":"https://dribbble.com/abcd",
                "personal":"https://www.hi.com/",
                "linkedIn":"https://linkedin.com/in/abcd",
                "other":"https://github.com/hackmcgill/hackerAPI/issues/168"
            }
        },
        "shortAnswer": {
            "skills":["Javascript","Typescript"],
            "question1": "I love McHacks",
            "question2":"Pls accept me",
            "comments":"hi!"
        },
        "other": {
            "gender": "male",
            "ethnicity": ["Asian or Pacific Islander"],
            "privacyPolicy": true,
            "codeOfConduct": true
        },
        "accommodation": {
            "travel": 0,
            "shirtSize": "S"
        }
    }
}

fails as it's missing previousHackathons

logan-r · 2020-10-17T15:44:02Z

middlewares/validators/validator.helper.js

                return false;
            }
-            if (!!model.searchableField(value)) {
+            if (model.searchableField(value)) {


Was this a boolean cast? !! is odd in an if, should be casting already, just want to make sure we don't break anything here

not sure, i think the lint took it off by itself, should i restore it to !!?

logan-r · 2020-10-17T15:54:40Z

package.json

    "name": "hackerAPI",
    "version": "3.0.0",
    "private": true,
    "scripts": {


Can you exclude this file from the commit?

yeah sure! mybad haha

Tony9984 · 2020-10-18T02:39:17Z

Looks good! Haven't run locally tho, can you confirm that:

a) Tests pass
b) You can POST localhost:3000/api/hacker with

{
    "accountId": "[AN EXISTING ACCOUNT ID]",
    "application":{
        "general":{
            "school": "McGill University",
            "degree": "Undergraduate",
            "fieldOfStudy": ["Computer Science"],
            "graduationYear": 2021,
            "jobInterest":"Internship",
            "URL":{
                "resume":"resumes/1543458163426-5bff4d736f86be0a41badb91",
                "github":"https://github.com/abcd",
                "dropler":"https://dribbble.com/abcd",
                "personal":"https://www.hi.com/",
                "linkedIn":"https://linkedin.com/in/abcd",
                "other":"https://github.com/hackmcgill/hackerAPI/issues/168"
            }
        },
        "shortAnswer": {
            "skills":["Javascript","Typescript"],
            "question1": "I love McHacks",
            "question2":"Pls accept me",
            "comments":"hi!",
            "previousHackathons": "0"
        },
        "other": {
            "gender": "male",
            "ethnicity": ["Asian or Pacific Islander"],
            "privacyPolicy": true,
            "codeOfConduct": true
        },
        "accommodation": {
            "travel": 0,
            "shirtSize": "S"
        }
    }
}

and it shows up in mongo

c) POSTing localhost:3000/api/hacker with

{
    "accountId": "[AN EXISTING ACCOUNT ID]",
    "application":{
        "general":{
            "school": "McGill University",
            "degree": "Undergraduate",
            "fieldOfStudy": ["Computer Science"],
            "graduationYear": 2021,
            "jobInterest":"Internship",
            "URL":{
                "resume":"resumes/1543458163426-5bff4d736f86be0a41badb91",
                "github":"https://github.com/abcd",
                "dropler":"https://dribbble.com/abcd",
                "personal":"https://www.hi.com/",
                "linkedIn":"https://linkedin.com/in/abcd",
                "other":"https://github.com/hackmcgill/hackerAPI/issues/168"
            }
        },
        "shortAnswer": {
            "skills":["Javascript","Typescript"],
            "question1": "I love McHacks",
            "question2":"Pls accept me",
            "comments":"hi!"
        },
        "other": {
            "gender": "male",
            "ethnicity": ["Asian or Pacific Islander"],
            "privacyPolicy": true,
            "codeOfConduct": true
        },
        "accommodation": {
            "travel": 0,
            "shirtSize": "S"
        }
    }
}

fails as it's missing previousHackathons

got it! here's what i have:

a) all tests pass! except for the 2 that i sent you on slack

b) returns a 500, debugging it right now
UPDATE: I believe it is caused by the 2 failing tests, which relates to the creation of a hacker when applications have closed/not opened. Let me know what you guys think

c) works as intended! 422 error, with previousHackathons as missing field

pierreTklein · 2020-10-19T14:30:24Z

Are you able to debug the 500 error?

logan-r · 2020-10-19T18:51:06Z

Ran tests on latest dev code & tests pass, meaning contrary to my thinking earlier on slack, this is a bug introduced by this PR

@Tony9984 I'm finishing up a midterm today, can help debug tomorrow if this is still an issue

Tony9984 · 2020-10-19T18:57:49Z

Are you able to debug the 500 error?

Tony9984 · 2020-10-19T18:59:54Z

hey guys! thanks for the updates! tried debugging it, couldn't find the issue, I'll try again tonight after my midterm. @logan-r good luck for yours!! hope everything goes well.

logan-r

Looks great!!

Tony9984 added 2 commits October 16, 2020 18:56

feat: add previous hackathons field to model, update tests

0e88775

Merge branch 'dev' into feature/669-Previous_hackathons

1b77b33

Tony9984 requested a review from logan-r October 16, 2020 23:00

Tony9984 linked an issue Oct 16, 2020 that may be closed by this pull request

Add number of previous hackathons field to application #669

Closed

logan-r reviewed Oct 17, 2020

View reviewed changes

fix: restore pushed package.json changes

c572ef6

Tony9984 closed this Oct 19, 2020

Tony9984 reopened this Oct 19, 2020

Tony9984 requested a review from logan-r October 20, 2020 22:54

Fix package.json

559a094

logan-r approved these changes Oct 20, 2020

View reviewed changes

logan-r changed the title ~~Feature/Add previous hackathons field to model~~ feat: add previous hackathons field to application Oct 20, 2020

Tony9984 merged commit 61266c2 into dev Oct 20, 2020

Tony9984 deleted the feature/669-Previous_hackathons branch October 20, 2020 23:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add previous hackathons field to application #670

feat: add previous hackathons field to application #670

Uh oh!

Tony9984 commented Oct 16, 2020 •

edited

Loading

Uh oh!

logan-r left a comment

Uh oh!

logan-r Oct 17, 2020

Uh oh!

Tony9984 Oct 18, 2020

Uh oh!

logan-r Oct 17, 2020

Uh oh!

Tony9984 Oct 18, 2020

Uh oh!

Tony9984 commented Oct 18, 2020 •

edited

Loading

Uh oh!

pierreTklein commented Oct 19, 2020

Uh oh!

logan-r commented Oct 19, 2020 •

edited

Loading

Uh oh!

Tony9984 commented Oct 19, 2020

Uh oh!

Tony9984 commented Oct 19, 2020

Uh oh!

logan-r left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: add previous hackathons field to application #670

feat: add previous hackathons field to application #670

Uh oh!

Conversation

Tony9984 commented Oct 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Tickets:

List of changes:

Type of change

How has this been tested?

Questions for code reviewers?

Checklist:

Uh oh!

logan-r left a comment

Choose a reason for hiding this comment

Uh oh!

logan-r Oct 17, 2020

Choose a reason for hiding this comment

Uh oh!

Tony9984 Oct 18, 2020

Choose a reason for hiding this comment

Uh oh!

logan-r Oct 17, 2020

Choose a reason for hiding this comment

Uh oh!

Tony9984 Oct 18, 2020

Choose a reason for hiding this comment

Uh oh!

Tony9984 commented Oct 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pierreTklein commented Oct 19, 2020

Uh oh!

logan-r commented Oct 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tony9984 commented Oct 19, 2020

Uh oh!

Tony9984 commented Oct 19, 2020

Uh oh!

logan-r left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Tony9984 commented Oct 16, 2020 •

edited

Loading

Tony9984 commented Oct 18, 2020 •

edited

Loading

logan-r commented Oct 19, 2020 •

edited

Loading