Skip to content

Conversation

@pierreTklein
Copy link
Member

Tickets:

List of changes:

  • feat: add isRemote boolean variable to SETTINGS schema (default value is false)
  • feat: add isRemote optional field to validation
  • feat: add test to update SETTINGS such that isRemote is true.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Patch SETTINGS to include isRemote=true.

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@pierreTklein pierreTklein requested a review from logan-r November 1, 2020 16:59
@pierreTklein
Copy link
Member Author

Not sure why api_data has 4k deletes.

Copy link
Member

@logan-r logan-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pierreTklein pierreTklein merged commit 5a34cd0 into dev Nov 1, 2020
@pierreTklein pierreTklein deleted the feat/674-IS_REMOTE_HACKATHON branch November 1, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants