Skip to content

fix: give admins full permissions when they create their account #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2020
Merged

fix: give admins full permissions when they create their account #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions middlewares/auth.middleware.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,13 +426,15 @@ async function validateConfirmationToken(req, res, next) {
}

/**
*
* Finds the confirmation token for this account. If there is no account ID associated with this
* confirmation token, then the user was invited. Therefore, we should set the confirmation bit to
* true by default (since they were invited).
* @param {body: {decodedToken:{accountConfirmationId: String}}} req
* @param {*} res
* @param {*} next
*/
async function validateConfirmationTokenWithoutAccount(req, res, next) {
if (!!req.body.decodedToken) {
if (req.body.decodedToken) {
const confirmationObj = await Services.AccountConfirmation.findById(
req.body.decodedToken.accountConfirmationId
);
Expand Down Expand Up @@ -468,17 +470,26 @@ function deleteResetToken(req, res, next) {
* @param {(err?)=>void} next
*/
async function addCreationRoleBindings(req, res, next) {
// Get the default role for the account type given
const roleName = Constants.General.POST_ROLES[req.body.account.accountType];
await Services.RoleBinding.createRoleBindingByRoleName(
req.body.account.id,
roleName
);
// Add default account role bindings
await Services.RoleBinding.createRoleBindingByRoleName(
req.body.account.id,
Constants.Role.accountRole.name
);
if (req.body.account.accountType === Constants.General.STAFF) {
// Staff do not have to create a STAFF object, so give them the full permissions immediately.
await Services.RoleBinding.createRoleBindingByRoleName(
req.body.account.id,
Constants.Role.adminRole.name
);
} else {
// Get the default role for the account type given
const roleName =
Constants.General.POST_ROLES[req.body.account.accountType];
await Services.RoleBinding.createRoleBindingByRoleName(
req.body.account.id,
roleName
);
// Add default account role bindings
await Services.RoleBinding.createRoleBindingByRoleName(
req.body.account.id,
Constants.Role.accountRole.name
);
}
return next();
}

Expand Down