Skip to content

Conversation

@logan-r
Copy link
Member

@logan-r logan-r commented Nov 12, 2020

Tickets:

List of changes:

  • GET /team/:id now returns schools and status of team members in format:
 {
  "message": "Team retrieval successful", 
  "data": {        
    "team": {
      "name":"foo",
      "members": [
        ObjectId('...')
      ],
      "devpostURL": "www.devpost.com/foo",
      "projectName": "fooey"
    },
    "members": [
      {
        "firstName": "John",
        "lastName": "Doe",
        "school": "McGill University",
        "status": "Applied"
      }
    ],
  }
}

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New release
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Modified it("should SUCCEED and list a team's information from /api/team/ GET") test case so test confirmed correct status and school were also returned.

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@logan-r logan-r merged commit de13a6d into dev Nov 15, 2020
@logan-r logan-r deleted the feat/684-team-members branch November 15, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants