Skip to content

Conversation

@pengyk
Copy link
Member

@pengyk pengyk commented Jun 10, 2021

Tickets:

List of changes:

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Improved performance of all tests from ~25min to ~9 min

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Ran all tests and passed all

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • [] Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@pengyk pengyk changed the title fix: improved account tests Fix/691 Improved test suite Jun 10, 2021
@pengyk pengyk marked this pull request as draft June 10, 2021 05:29
@pengyk pengyk linked an issue Jun 10, 2021 that may be closed by this pull request
@pengyk pengyk temporarily deployed to testing June 27, 2021 04:19 Inactive
@pengyk pengyk marked this pull request as ready for review June 27, 2021 04:19
@jamesxu123 jamesxu123 self-requested a review June 29, 2021 15:23
@jamesxu123 jamesxu123 merged commit 8da6b2a into dev Jun 29, 2021
@jamesxu123 jamesxu123 deleted the fix/691-Improve_test_suite_performance branch June 29, 2021 15:24
logan-r pushed a commit that referenced this pull request Nov 29, 2021
* fix: improved account tests

* empty: trigger CI

* empty: trigger github actions

* fixed: added all improvements

Co-authored-by: James Xu <36768789+jamesxu123@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate test suite for performance issues

3 participants