-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add dependabot #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dependabot #703
Conversation
|
Before merging this and letting Dependabot loose on at least a full year of stale dependencies, I'd suggest updating as many as you can in one shot first to give it a head start. Since it produces a PR for every single out of date dependency, it'll create a lot of noise we can solve faster+easier in one shot. |
.github/dependabot.yml
Outdated
| - package-ecosystem: "npm" # See documentation for possible values | ||
| directory: "/" # Location of package manifests | ||
| schedule: | ||
| interval: "daily" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a conversation to be had around weekly vs. daily. IMO - daily is fine if the Auto-merging Github Action I mentioned in the issue is implemented and we trust the CI/CD enough.
Edit: Issue #702
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the auto-merge is something to be explored and it would make things a lot easier. However, we're in the middle of making a lot of changes to the test suite to speed it up so it's probably safer if we go with weekly + manual review for now.
If everything goes well, making it automated would be a great future addition and I'll add it to the dev road map for the year.
Ran |
|
Also, a similar setup should probably be implemented on the dashboard repo. |
* Create dependabot.yml * chore: update dependencies * fix: update EmailService.send to be compatible * style: remove commented code * fix: sendMultiple * change dependabot weekly
Tickets:
List of changes:
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Firmware version:
Hardware:
Toolchain:
SDK:
Questions for code reviewers?
Checklist: