Skip to content

Conversation

@brarsanmol
Copy link
Member

Changelog

  • Forgotten account confirmation check on the findSelf function in the hacker middleware allowed constant 409 requests.
  • IMPORTANT: This issue has a ripple effect in the sponsor and volunteer middleware from what i understand as the code is the same in the findSelf functions in both classes.
    • I would recommend patching both or resolving the e-mail billing issue before the sponsor and volunteer onboarding.

Type of Change:

  • Bug fix (non-breaking change which fixes an issue)

Testing Methods?

  • The behaviour from the bug has been resolved and now the page shows.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

…ation check.

- forgotten account confirmation check on the findSelf function in the hacker middleware allowed constant 409 requests.
- IMPORTANT: this issue has a ripple effect in the sponsor and volunteer middleware from what i understand as the code is the same in the findSelf functions in both classes.
  - i would recommend patching both or resolving the e-mail billing issue before the sponsor and volunteer onboarding.
@brarsanmol brarsanmol added bug Something isn't working Pri 0 Highest priority labels Dec 6, 2021
@brarsanmol brarsanmol requested a review from logan-r December 6, 2021 18:54
@brarsanmol brarsanmol self-assigned this Dec 6, 2021
@meldunn meldunn self-requested a review December 6, 2021 19:27
@meldunn meldunn merged commit 2e3fd15 into dev Dec 6, 2021
@meldunn meldunn deleted the fix/app-submitted-page branch December 6, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Pri 0 Highest priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants