Feat/assign reviewers #959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Will need a cleaning for documentation
…'s just filtering if hacker was created before cutoff)
tektaxi
commented
Nov 19, 2025
| uri: "/api/hacker/reviewerComments2/" + Constants.ROLE_CATEGORIES.SELF, | ||
| _id: mongoose.Types.ObjectId.createFromTime(179) | ||
| }, | ||
| // patchAnyReviewerNameById: { |
Contributor
Author
There was a problem hiding this comment.
this is all commented out, can we just delete it? is there a reason to keep?
|
|
||
|
|
||
| /** | ||
| * Updates a hacker that is specified by req.params.id, and then sets req.email |
Contributor
Author
There was a problem hiding this comment.
make this comment accurate? i think it's just copy pasted?
| */ | ||
| hackerRouter.route("/assignReviewers").post( | ||
| // Middleware.Validator.RouteParam.idValidator, | ||
| // Middleware.Auth.ensureAuthenticated(), |
Contributor
Author
There was a problem hiding this comment.
let's try to enable the auth ones at least
Contributor
Author
There was a problem hiding this comment.
we should also add this route to the Hackboard role "excludes"
Contributor
Author
There was a problem hiding this comment.
wait i just realized if we're running this as a script for now we can't have these on
Contributor
Author
|
overriding review requirements because it's basically Jamie's PR and I approve |
Contributor
Author
|
@JamieXiao make sure to address comments in the next one, just merging bc we have to use tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #957 for details.