Skip to content

HCK-11878: FE additional properties only when its false #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 4, 2025
Merged

HCK-11878: FE additional properties only when its false #86

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5683491
HCK-11878: FE additionalProperties only when false or undefined
Jul 3, 2025
82f7c4f
HCK-11878: fixed condition
Jul 4, 2025
38b23c2
HCK-11878: make condition more robust
Jul 4, 2025
beea544
HCK-11878: make condition more explicit
Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion forward_engineering/helpers/typeHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,11 @@ function getAdditionalProperties(data) {
}

if (data.additionalPropControl === 'Boolean') {
return data.additionalProperties || undefined;
/**
* additionalProperties property should be omitted when the value is equal to "true" because it is enabled by default.
* In case the property is missing or false it is explicitly included with "false" value
*/
return data.additionalProperties ? undefined : false;
}

return getAdditionalPropsObject(data);
Expand Down