Skip to content

HCK-12591: performance improvements for RE of large schema #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

HCK-12591: performance improvements for RE of large schema #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion forward_engineering/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,7 @@
"value": false
}
],
"isApiSchema": true
"isApiSchema": true,
"disableJSONDataGeneration": true,
"disableAttributesSorting": true
}
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@
"propertyNames": [
"schemas"
]
}
},
"collapseEntityAttributesInRE": true
}
},
"description": "Hackolade plugin for OpenAPI",
Expand Down
7 changes: 6 additions & 1 deletion reverse_engineering/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,11 +167,16 @@ const handleOpenAPIData = (openAPISchema, fieldOrder) =>
try {
const convertedData = convertOpenAPISchemaToHackolade(openAPISchema, fieldOrder);
const { modelData, modelContent, definitions } = convertedData;
let modelDefinitionsWereSet = false;
const hackoladeData = modelContent.containers.reduce((accumulator, container) => {
const currentEntities = modelContent.entities[container.name];
return [
...accumulator,
...currentEntities.map((entity, index) => {
const shouldSetModelDefinitions = !modelDefinitionsWereSet;
if (shouldSetModelDefinitions) {
modelDefinitionsWereSet = true;
}
const packageData = {
objectNames: {
collectionName: entity.collectionName,
Expand All @@ -180,7 +185,7 @@ const handleOpenAPIData = (openAPISchema, fieldOrder) =>
dbName: container.name,
collectionName: entity.collectionName,
bucketInfo: container,
...(index === 0 && { modelDefinitions: definitions }),
...(shouldSetModelDefinitions && { modelDefinitions: definitions }),
},
jsonSchema: JSON.stringify(entity),
};
Expand Down