Skip to content

HCK-9173: comment out inactive schema statement in script #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 19, 2024
Merged

HCK-9173: comment out inactive schema statement in script #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edca932
HCK-9173: comment out inactive schema statement in script
AlikRakhmonov Dec 19, 2024
c436a9e
fix undefined
AlikRakhmonov Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions forward_engineering/ddlProvider/ddlProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ module.exports = (baseProvider, options, app) => {
});
},

createSchema({ schemaName, ifNotExist, comments, udfs, procedures }) {
createSchema({ schemaName, ifNotExist, comments, udfs, procedures, sequences, isActivated = true }) {
const comment = assignTemplates(templates.comment, {
object: 'SCHEMA',
objectName: wrapInQuotes(schemaName),
Expand All @@ -83,12 +83,14 @@ module.exports = (baseProvider, options, app) => {
const createFunctionStatement = getFunctionsScript(schemaName, udfs);
const createProceduresStatement = getProceduresScript(schemaName, procedures);

return _.chain([schemaStatement, createFunctionStatement, createProceduresStatement])
const statement = _.chain([schemaStatement, createFunctionStatement, createProceduresStatement])
.compact()
.map(_.trim)
.join('\n\n')
.trim()
.value();

return commentIfDeactivated(statement, { isActivated });
},

createTable(
Expand Down Expand Up @@ -667,6 +669,7 @@ module.exports = (baseProvider, options, app) => {
procedures: data?.procedures || [],
sequences: data?.sequences || [],
dbVersion,
isActivated: containerData.isActivated,
};
},

Expand Down