Add device info #9
Conversation
| { title: 'Total Memory (Bytes)', identifier: 'totalMemory' }, | ||
| { title: 'Uptime', identifier: 'uptime' }, | ||
| { title: 'Jail Broken', identifier: 'isJailBroken' }, | ||
| ]; No newline at end of file |
There was a problem hiding this comment.
Missing empty line at the end of the file
features/expo/deviceInfo/enums.ts
Outdated
| TABLET = 2, | ||
| DESKTOP = 3, | ||
| TV = 4, | ||
| } No newline at end of file |
There was a problem hiding this comment.
Missing empty line at the end of the file
features/expo/deviceInfo/hooks.ts
Outdated
| Promise.all([ | ||
| Device.getDeviceTypeAsync(), | ||
| Device.getUptimeAsync(), | ||
| Device.isRootedExperimentalAsync(), | ||
| ]) |
There was a problem hiding this comment.
Please use separate promises. This will fail on all, even if only one promise fails.
features/expo/deviceInfo/index.tsx
Outdated
|
|
||
| import { Card, Text, View } from 'react-native-ui-lib'; | ||
|
|
||
| import { useDeviceInfo } from 'htk/features/expo/deviceInfo/hooks'; |
There was a problem hiding this comment.
Let's use relative imports since this is a repo that is being used as submodule.
This is forcing us to use htk path alias. We still did not discuss about the standard path alias.
features/expo/deviceInfo/hooks.ts
Outdated
| @@ -0,0 +1,66 @@ | |||
| import { useEffect, useState } from 'react'; | |||
|
|
|||
| import { enumToStr } from 'htk/utils/enum'; | |||
There was a problem hiding this comment.
Same here. Let's use relative imports.
features/expo/deviceInfo/hooks.ts
Outdated
| }); | ||
|
|
||
| useEffect(() => { | ||
| const fetchDeviceInfo = async () => { |
There was a problem hiding this comment.
Incorrect. Please use .then() structure.
Device.getDeviceTypeAsync().then(deviceType => {
setDeviceInfo(prev => ({...prev, deviceType: enumToStr(DeviceType, deviceType})
})).catch(error => {
console.error('Failed to fetch device type:', error);
});Please apply to the other async functions as well.
gwainor
left a comment
gwainor
left a comment
There was a problem hiding this comment.
Also please fix you IDE to apply prettier on save or something.
Your prettier is not formatting the code.
features/expo/deviceInfo/hooks.ts
Outdated
| Device.getDeviceTypeAsync().then(deviceType => { | ||
| setDeviceInfo(prev => ({...prev, deviceType: deviceType ? enumToStr(DeviceType, deviceType) : null})); |
There was a problem hiding this comment.
If there is a null possibility of the deviceType variable, there is no need to update the state.
| Device.getDeviceTypeAsync().then(deviceType => { | |
| setDeviceInfo(prev => ({...prev, deviceType: deviceType ? enumToStr(DeviceType, deviceType) : null})); | |
| Device.getDeviceTypeAsync().then(deviceType => { | |
| if (deviceType) { | |
| setDeviceInfo(prev => ({...prev, deviceType: enumToStr(DeviceType, deviceType)})); | |
| } |
4 participants
Added device info menu for the expo project