This repository was archived by the owner on May 14, 2024. It is now read-only.
Homework week1 #18
Closed
Homework week1 #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harditsingh
reviewed
Jun 15, 2018
harditsingh
left a comment
harditsingh
left a comment
There was a problem hiding this comment.
Amazing job Husam! The website and the code look great! I have a few concerns though, please check the comments below.
| return response; | ||
|
|
||
| } else if (xhr.status === 404) { | ||
| console.log("Error: resource not found"); |
There was a problem hiding this comment.
The assignment says that you have to display the error on the screen, printing it to console isn't effective enough as people don't usually check the console log.
| let header = createAndAppend("header", root) | ||
| let selectTag = createAndAppend("select", header); | ||
|
|
||
| let wrapper = createAndAppend("div", root); |
There was a problem hiding this comment.
While the code looks amazing, this should have been wrapped in a main() function.
| objects.forEach(object => { | ||
| let optionTag = createAndAppend("option", selectTag); | ||
| optionTag.value = object.name; | ||
| optionTag.textContent = object.name; |
There was a problem hiding this comment.
You forgot to sort the options of the drop-down menu in an alphabetical order.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codepen link