This repository was archived by the owner on May 14, 2024. It is now read-only.
added JS3 homework week1 #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harditsingh
reviewed
Jun 24, 2018
harditsingh
left a comment
harditsingh
left a comment
There was a problem hiding this comment.
Good job Dumie! Your code looks pretty good, but some things can be improved. Cheers!
|
|
||
| function repoData(error, data) { | ||
| if (error !== null) { | ||
| console.error(error); |
There was a problem hiding this comment.
You should not print the error to the console as the user would never know what went wrong. Instead, you should show the error on the webpage
| const root = document.getElementById('root'); | ||
|
|
||
| root.innerHTML = null; | ||
| fetchJSON("https://api.github.com/orgs/HackYourFuture/repos?per_page=100", repoData); |
There was a problem hiding this comment.
You should not use URLs like this, you should put them in a variable instead. Without a variable, it can get confusing when you try to reuse the code or try to change something
| for (const obj of arrayOfObjects) { | ||
| const optionItem = createAndAppend('option', select); | ||
| optionItem.innerText = obj.name; | ||
| optionItem.value = 'https://api.github.com/repos/HackYourFuture/' + obj.name; |
There was a problem hiding this comment.
You forgot to sort the elements of the drop-down menu
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added javascript3 homework week1. Not really confident with my index.js file or code...