This repository was archived by the owner on May 14, 2024. It is now read-only.
homework week1 added #24
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harditsingh
reviewed
Jun 24, 2018
harditsingh
left a comment
harditsingh
left a comment
There was a problem hiding this comment.
You did a great job on the assignment and the code looks pretty good! I have put some comments though, please go through them once. Good luck!
| function renderContributorsInformationToDom() { | ||
|
|
||
| let hyfRepositoryAtTheMoment = repositoryNameLink.innerText; | ||
| const gitHubUrl = 'https://api.github.com/repos/HackYourFuture/' + hyfRepositoryAtTheMoment + '/contributors'; |
There was a problem hiding this comment.
You should not put the URL inside functions and in multiple places, it can get confusing really quickly
| const hyfRepositoriesRequest = new XMLHttpRequest(); | ||
| hyfRepositoriesRequest.open('GET', gitHubUrl, true); | ||
| hyfRepositoriesRequest.send(); | ||
| hyfRepositoriesRequest.onreadystatechange = repositoriesRequest; |
There was a problem hiding this comment.
You have not handled any errors if server is not available. This way the user doesn't know why the website is not working when a server is not available.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know my code looks like a chaos but everything works perfectly. I started in this way and i had nothing to do but continue. I really appriciate it if you can tell me how and where in my code, could i make it easier .Last thing to say ,the css part is really simple because it has been done in no time. thanks for your feedback in advance.