Week3 - classes homework

[sima-milli]

No description provided.

[profxed]

Nicely Done !!

As usual making a very good steps, nice Implementing for classes, I liked your adjustment for the fetchJSON function.
this is not usual, but you have to clean your code a bit when you finish your work.

I left for you a very minor tiny comments, I hope that I didn't miss any thing 🙂.

[profxed]

you can Change this to be:

if (xhr.readyState === xhr.DONE) { // your way same as this, it's included inside the prototype chain.
  // 1. would make more sense 
  // 2. if you have another way than the magic numbers doing
  // -- the same thing you should use it otherwise you should 
  // -- put a little comment telling what the magic number is!!

  // the rest of the code...
}

[profxed]

This is how it should be implemented 🥇

[profxed]

I see that you have too much creating tr, td tags, For my perspective in this case you should create a function, that may make your life easier.

const createTableRow = (parent=table || null, options={}) => {
  const row = createAndAppend('tr', parent);
  const label = createAndAppend('td', row, options);
  return { row, label }
}

Also from line 57 till here you have an innerHTML or 'innerText' multiple times for the same table item, couldn't be like so if you followed my advice for the function:

repository.description ? createTableRow(table, {
            html: 'Description :',
            class: 'label'
        }) : ''

Note:
You have to change it until it fit into your code, BUT the same Idea.

[sima-milli]

I tried to do that but in my code I use the name of the row and td, but I thing you manged that by returning {row, label} I'll try that 👍

[profxed]

console.log is only for development purposes

[sima-milli]

Yeah sorry I forgot to delete it :)

[profxed]

if not falsey value which means if a truthy value, that you can do it like so:
if (table2) {/* you code */}

[profxed]

I think these you can Apply the same thing as index.js file