Skip to content

Conversation

@rvhonorato
Copy link
Member

@rvhonorato rvhonorato commented Oct 9, 2024

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines.

Checklist

  • Tests added for the new code
  • Documentation added for the code changes
  • Does not break licensing
  • Does not add any dependencies, if it does please add a thorough explanation

Summary of the Pull Request

This PR removes the logic path that used the less_io parameter - which was then changed to debug - to decide how to retrieve the information from the Scheduler.

It also fixes #1081 just by changing the type of CAPRI.identificator to an integer, this ensures the engine.result can be sorted and move on in the expected order. To check for this bug I added a new integration test test_ss_clt_relation that checks if the metrics in the capri_ss.tsv and capri_clt.tsv match, so I also had to add a bunch of PDBs as golden data.

Related Issue

#928, #1081

Additional Info

@rvhonorato rvhonorato linked an issue Oct 9, 2024 that may be closed by this pull request
@rvhonorato rvhonorato marked this pull request as ready for review October 9, 2024 13:48
@rvhonorato rvhonorato enabled auto-merge October 9, 2024 13:48
@rvhonorato rvhonorato requested review from a team and mgiulini October 9, 2024 13:48
@rvhonorato rvhonorato self-assigned this Oct 9, 2024
@rvhonorato rvhonorato added the m|caprieval Improvements in caprieval module label Oct 9, 2024
@rvhonorato rvhonorato requested review from a team and VGPReys October 10, 2024 11:57
@rvhonorato rvhonorato merged commit a9f9c13 into main Oct 10, 2024
4 checks passed
@rvhonorato rvhonorato deleted the 1081-wrong-numbers-in-capri_clt branch October 10, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

m|caprieval Improvements in caprieval module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong numbers in capri_clt

4 participants