Skip to content

Conversation

@joaomcteixeira
Copy link
Member

@joaomcteixeira joaomcteixeira commented Nov 10, 2021

Lints the code so far.

@joaomcteixeira joaomcteixeira added the enhancement Improving something in the codebase label Nov 10, 2021
@joaomcteixeira joaomcteixeira self-assigned this Nov 10, 2021
@joaomcteixeira joaomcteixeira added this to the v3.0.0 stable release milestone Nov 10, 2021
@joaomcteixeira
Copy link
Member Author

Now that all tests pass. No PR be merged with any red cross 😉 (surely exceptions apply).

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #113 (e4babaf) into main (6c802df) will decrease coverage by 0.29%.
The diff coverage is 65.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   43.73%   43.43%   -0.30%     
==========================================
  Files          38       38              
  Lines        1891     1874      -17     
==========================================
- Hits          827      814      -13     
+ Misses       1064     1060       -4     
Impacted Files Coverage Δ
src/haddock/core/exceptions.py 100.00% <ø> (ø)
src/haddock/gear/haddockmodel.py 11.62% <0.00%> (ø)
src/haddock/gear/restart_run.py 61.53% <ø> (ø)
src/haddock/libs/libmath.py 80.00% <ø> (ø)
src/haddock/libs/libparallel.py 33.33% <ø> (ø)
src/haddock/libs/libstructure.py 50.00% <ø> (ø)
src/haddock/libs/libsubprocess.py 33.33% <ø> (-2.84%) ⬇️
src/haddock/libs/libutil.py 46.55% <ø> (-0.91%) ⬇️
src/haddock/modules/sampling/gdock/__init__.py 20.45% <0.00%> (ø)
src/haddock/modules/sampling/lightdock/__init__.py 17.85% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c802df...e4babaf. Read the comment docs.

Copy link
Member

@rvhonorato rvhonorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting is awesome! :)

@joaomcteixeira joaomcteixeira merged commit d5f5cd8 into haddocking:main Nov 11, 2021
@joaomcteixeira joaomcteixeira deleted the linting branch November 11, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improving something in the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants