- 
                Notifications
    
You must be signed in to change notification settings  - Fork 53
 
          Further cleaning of the topoaa, rigidbody and  flexref modules
          #127
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           flexref part is working, but required further cleaning  | 
    
          Codecov Report
 @@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   43.41%   43.32%   -0.10%     
==========================================
  Files          38       38              
  Lines        1875     1879       +4     
==========================================
  Hits          814      814              
- Misses       1061     1065       +4     
 Continue to review full report at Codecov. 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has multiple changes over multiple modules with 119 file changes. I cannot check everything, will trust @amjjbonvin on it 🧙🏽
| output += (f"eval ($output_pdb_filename=" | ||
| f" \"{output_pdb_filename}\"){linesep}") | ||
| output += (f"eval ($count=" | ||
| f" {identifier}){linesep}") | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identifier here starts at 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes - this is still how models are numbered currently, starting at 0 instead of 1 (which might be more logical from a user perspective)
topoaa, rigidbody and  flexref modules
      | 
           Rodrigo was updating the examples PDB to  I will correct the model_0 issue a new PR, now  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have added already everything you needed go forward merging it.
| 
           Will keep working on the other modules - by merging this one already  | 
    
| 
           👏 🚀 🎸  | 
    
The
topoaamodule is still giving some errors (even if working) because the python machinery ois not writing to the CNS input file the molecule-specific parameters defined in the default config.E.g.:
This should be corrected (open issue #125)
This pull request should also address issue #126
closes #125 and closes #126