Skip to content

Conversation

@amjjbonvin
Copy link
Member

@amjjbonvin amjjbonvin commented Nov 22, 2021

The topoaa module is still giving some errors (even if working) because the python machinery ois not writing to the CNS input file the molecule-specific parameters defined in the default config.

E.g.:

[input.mol1]
prot_segid = 'A'
fix_origin = false
dna = false
shape = false
cg = false
cyclicpept = false

This should be corrected (open issue #125)

This pull request should also address issue #126


closes #125 and closes #126

@amjjbonvin
Copy link
Member Author

flexref part is working, but required further cleaning

@codecov-commenter
Copy link

Codecov Report

Merging #127 (bd209f7) into main (c3651f6) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   43.41%   43.32%   -0.10%     
==========================================
  Files          38       38              
  Lines        1875     1879       +4     
==========================================
  Hits          814      814              
- Misses       1061     1065       +4     
Impacted Files Coverage Δ
src/haddock/libs/libcns.py 14.20% <0.00%> (-0.26%) ⬇️
src/haddock/modules/refinement/flexref/__init__.py 22.66% <0.00%> (-0.31%) ⬇️
src/haddock/modules/sampling/rigidbody/__init__.py 22.07% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3651f6...bd209f7. Read the comment docs.

Copy link
Member

@rvhonorato rvhonorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has multiple changes over multiple modules with 119 file changes. I cannot check everything, will trust @amjjbonvin on it 🧙🏽

output += (f"eval ($output_pdb_filename="
f" \"{output_pdb_filename}\"){linesep}")
output += (f"eval ($count="
f" {identifier}){linesep}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identifier here starts at 0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - this is still how models are numbered currently, starting at 0 instead of 1 (which might be more logical from a user perspective)

@rvhonorato rvhonorato changed the title Further cleaning of the topoaa and rigidbody modules Further cleaning of the topoaa, rigidbody and flexref modules Nov 22, 2021
@joaomcteixeira
Copy link
Member

Rodrigo was updating the examples PDB to 2OOB. You might wish to use them here also. Otherwise, we can change that in the future in another PR. It is not clear to me if you made all changes you wanted in this PR. If so, go ahead 😉

I will correct the model_0 issue a new PR, now

Copy link
Member

@joaomcteixeira joaomcteixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have added already everything you needed go forward merging it.

@amjjbonvin
Copy link
Member Author

Will keep working on the other modules - by merging this one already

@amjjbonvin amjjbonvin merged commit 15438d2 into main Nov 22, 2021
@joaomcteixeira
Copy link
Member

👏 🚀 🎸

@amjjbonvin amjjbonvin deleted the haddock3-cns-clean branch November 23, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Definition of input PDB files in the CNS scripts All parameters defined in a cfg file should be passed to the CNS scripts

5 participants