Skip to content

Conversation

@rvhonorato
Copy link
Member

Small tweak to the logs, think we missed some in #159

@rvhonorato rvhonorato self-assigned this Dec 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2021

Codecov Report

Merging #188 (438932b) into main (af73260) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   41.50%   41.39%   -0.11%     
==========================================
  Files          41       41              
  Lines        2272     2278       +6     
==========================================
  Hits          943      943              
- Misses       1329     1335       +6     
Impacted Files Coverage Δ
src/haddock/modules/analysis/caprieval/__init__.py 12.00% <0.00%> (-0.25%) ⬇️
src/haddock/modules/topology/topoaa/__init__.py 20.93% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af73260...438932b. Read the comment docs.

Copy link
Member

@joaomcteixeira joaomcteixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine many more of these will come. That's good ☺️

Did you notice the self.log stuff added in #159 ? ☺️ Now you get the module name in the log and the parent run works as a decorator for child _run of each module 😉 very handy and cool.

@joaomcteixeira joaomcteixeira merged commit d537cfd into main Dec 8, 2021
@joaomcteixeira joaomcteixeira deleted the tweak-log branch December 8, 2021 12:59
@rvhonorato
Copy link
Member Author

I imagine many more of these will come. That's good ☺️

Did you notice the self.log stuff added in #159 ? ☺️ Now you get the module name in the log and the parent run works as a decorator for child _run of each module 😉 very handy and cool.

I did yes, very nice! How do you add the warnings and errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants