Skip to content

Conversation

@mgiulini
Copy link
Contributor

@mgiulini mgiulini commented Jun 3, 2022

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #386. @amjjbonvin Now the calculation of the cluster-based caprieval scores is correct even if the cluster is underpopulated.

@mgiulini mgiulini added bug Something isn't working m|caprieval Improvements in caprieval module labels Jun 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2022

Codecov Report

Merging #460 (105d4ee) into main (7d5d4e1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
- Coverage   71.02%   71.01%   -0.02%     
==========================================
  Files          91       91              
  Lines        5743     5741       -2     
==========================================
- Hits         4079     4077       -2     
  Misses       1664     1664              
Impacted Files Coverage Δ
src/haddock/modules/analysis/caprieval/capri.py 78.60% <100.00%> (-0.12%) ⬇️
tests/test_module_caprieval.py 96.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5d4e1...105d4ee. Read the comment docs.

@rvhonorato rvhonorato merged commit e855629 into main Jun 3, 2022
@rvhonorato rvhonorato deleted the issue_386 branch June 3, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working m|caprieval Improvements in caprieval module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Amend clt_threshold behaviour

4 participants