Skip to content

added check on tolerance in clustrmsd #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 22, 2022
Merged

added check on tolerance in clustrmsd #489

merged 3 commits into from
Jun 22, 2022

Conversation

@mgiulini
Copy link
Contributor

@mgiulini mgiulini commented Jun 22, 2022 •
edited
Loading

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #488. I will add an example file of the overall execution in issue #417 and the related PR.

@mgiulini mgiulini requested a review from joaomcteixeira June 22, 2022 12:26
@mgiulini mgiulini self-assigned this Jun 22, 2022
@mgiulini mgiulini changed the title Iss488 added check on tolerance in clustrmsd Jun 22, 2022
@mgiulini mgiulini merged commit 00c49dc into main Jun 22, 2022
@mgiulini mgiulini deleted the iss488 branch June 22, 2022 13:02
@joaomcteixeira joaomcteixeira added m|clustrmsd enhancement Improving something in the codebase labels Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joaomcteixeira joaomcteixeira joaomcteixeira approved these changes

Assignees

@mgiulini mgiulini

Labels

enhancement Improving something in the codebase m|clustrmsd

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add check on tolerance in clustrmsd

3 participants

@mgiulini @joaomcteixeira