Skip to content

Conversation

@amjjbonvin
Copy link
Member

@amjjbonvin amjjbonvin commented Dec 22, 2022

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and you comply with the following criteria:

  • You have stick to Python. Talk with us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there's a (state) purpose
  • code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any install dependencies unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

The last commit #599 broke the execution on OSX. This fix makes it work (tested both on OSX and Linux). The solution proposed by @mgiulini was to change os.ST_WRITE with stat.S_IWUSR in src/haddock/libs/libio.py

@amjjbonvin amjjbonvin added the bug Something isn't working label Dec 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Base: 73.63% // Head: 73.63% // No change to project coverage 👍

Coverage data is based on head (ce329a6) compared to base (ab15b98).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   73.63%   73.63%           
=======================================
  Files         107      107           
  Lines        6942     6942           
=======================================
  Hits         5112     5112           
  Misses       1830     1830           
Impacted Files Coverage Δ
src/haddock/libs/libio.py 77.07% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mgiulini mgiulini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the solution on linux as well, it seems to be working fine!

@amjjbonvin amjjbonvin merged commit b62fb2f into main Dec 22, 2022
@amjjbonvin amjjbonvin deleted the issue598 branch December 22, 2022 14:52
@joaomcteixeira
Copy link
Member

nice 1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants