Skip to content

Remove duplicated key in src/haddock/modules/refinement/flexref/defaults.yaml #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2023
Merged

Remove duplicated key in src/haddock/modules/refinement/flexref/defaults.yaml #630

merged 1 commit into from
Feb 28, 2023

Conversation

@rvhonorato
Copy link
Member

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Delete this line and explain your PR here

@rvhonorato rvhonorato added the bug Something isn't working label Feb 28, 2023
@rvhonorato rvhonorato requested a review from mgiulini February 28, 2023 09:46
@rvhonorato rvhonorato self-assigned this Feb 28, 2023
@rvhonorato rvhonorato linked an issue Feb 28, 2023 that may be closed by this pull request
Duplicated parameter key #629
Closed
@rvhonorato
Copy link
Member Author

No idea why the tests are failing, probably something related to the coverage upload

@rvhonorato rvhonorato merged commit ab8f6c6 into main Feb 28, 2023
@rvhonorato rvhonorato deleted the 629-duplicated-parameter-key branch February 28, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgiulini mgiulini mgiulini approved these changes

Assignees

@rvhonorato rvhonorato

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicated parameter key

3 participants

@rvhonorato @mgiulini