Skip to content

Conversation

@SarahAlidoost
Copy link
Contributor

@SarahAlidoost SarahAlidoost commented Jun 14, 2023

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

closes #665, please see my comment that shows the hover text including caprieval_rank.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.33 ⚠️

Comparison is base (b361ef7) 74.73% compared to head (bcad4ad) 74.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
- Coverage   74.73%   74.41%   -0.33%     
==========================================
  Files         111      111              
  Lines        7644     7642       -2     
==========================================
- Hits         5713     5687      -26     
- Misses       1931     1955      +24     
Impacted Files Coverage Δ
src/haddock/libs/libplots.py 96.72% <100.00%> (-0.03%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@SarahAlidoost SarahAlidoost marked this pull request as ready for review June 14, 2023 12:22
@SarahAlidoost
Copy link
Contributor Author

@mgiulini and @amjjbonvin can you please review this pull request?

Copy link
Member

@amjjbonvin amjjbonvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and useful!

@mgiulini
Copy link
Contributor

well done, thanks!

@mgiulini mgiulini merged commit 27321d5 into haddocking:main Jun 21, 2023
@SarahAlidoost SarahAlidoost deleted the add_rank_to_plots branch June 21, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add rank info to interactive graphs

4 participants