Skip to content

Conversation

@SarahAlidoost
Copy link
Contributor

@SarahAlidoost SarahAlidoost commented Aug 24, 2023

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • [ ] Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • [ ] You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • [ ] Your PR is about writing documentation for already existing code 🔥
  • [ ] Your PR is about writing tests for already existing code :godmode:

As discussed before, we can move the codes of ngl viewer to the React component https://github.com/i-VRESSE/haddock3-analysis-components. In this pull request, changes are made to use the React component inside the HTML report code. Please run the haddock3-analyse command and inspect the report.html file.
Related to i-VRESSE/haddock3-analysis-components#5 and i-VRESSE/haddock3-analysis-components#7

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% ⚠️

Comparison is base (6098899) 75.01% compared to head (7b37adc) 74.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
- Coverage   75.01%   74.90%   -0.11%     
==========================================
  Files         113      113              
  Lines        8060     8022      -38     
==========================================
- Hits         6046     6009      -37     
+ Misses       2014     2013       -1     
Files Changed Coverage Δ
src/haddock/libs/libplots.py 96.93% <100.00%> (-0.07%) ⬇️
tests/test_libplots.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahAlidoost SarahAlidoost marked this pull request as ready for review September 11, 2023 14:02
@SarahAlidoost
Copy link
Contributor Author

@sverhoeven and @rvhonorato can you please review this PR? thanks.

Copy link
Contributor

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran haddock3-analyse and the structure viewer and download still work.

@SarahAlidoost
Copy link
Contributor Author

@rvhonorato or @mgiulini I think this pull request is ready to be merged.

@rvhonorato rvhonorato merged commit d7009a6 into haddocking:main Sep 13, 2023
@SarahAlidoost SarahAlidoost deleted the use_ngl_component branch September 14, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants