-
Notifications
You must be signed in to change notification settings - Fork 53
Use ngl component #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ngl component #683
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
- Coverage 75.01% 74.90% -0.11%
==========================================
Files 113 113
Lines 8060 8022 -38
==========================================
- Hits 6046 6009 -37
+ Misses 2014 2013 -1
☔ View full report in Codecov by Sentry. |
|
@sverhoeven and @rvhonorato can you please review this PR? thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran haddock3-analyse and the structure viewer and download still work.
|
@rvhonorato or @mgiulini I think this pull request is ready to be merged. |
You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:
[ ] Your PR is about CNS[ ] You wrote tests for the new codetoxtests pass. Runtoxcommand inside the repository folder-test.cfgexamples execute without errors. Insideexamples/runpython run_tests.py -b[ ] Your PR is about writing documentation for already existing code 🔥[ ] Your PR is about writing tests for already existing code
As discussed before, we can move the codes of ngl viewer to the React component https://github.com/i-VRESSE/haddock3-analysis-components. In this pull request, changes are made to use the React component inside the HTML report code. Please run the haddock3-analyse command and inspect the report.html file.
Related to i-VRESSE/haddock3-analysis-components#5 and i-VRESSE/haddock3-analysis-components#7