Implement type annotations #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add function and variable annotations
rvhonorato
added
the
CI / repository
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
+ Coverage 75.21% 75.47% +0.26%
==========================================
Files 114 115 +1
Lines 8068 8205 +137
==========================================
+ Hits 6068 6193 +125
- Misses 2000 2012 +12
☔ View full report in Codecov by Sentry. |
mgiulini
previously approved these changes
Oct 17, 2023
|
It would be nice to add py.typed file see https://peps.python.org/pep-0561/#packaging-type-information |
|
That looks interesting indeed @sverhoeven - I'll do it in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues #645;
Many type annotations were added, and where the code was too esoteric, I added
type: ignore. I have also updated the actions to runmypybefore running the tests.Since it support gradual typing and typing is not the norm, I've set it so that only the (new) typed functions should be checked - new untyped code should not be affected.