-
Notifications
You must be signed in to change notification settings - Fork 53
Side by side2 #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Side by side2 #799
Conversation
|
hey @sverhoeven , does this take also care of showing the top 4 models even when not all clusters have four models? I already developed some code that takes care of that issue, let me know |
|
@mgiulini it does for example Also notice the std dev is not shown if 0. |
|
The CI integration workflow (https://github.com/haddocking/haddock3/actions/runs/7916792483/job/21611546576?pr=799) is complaining about missing cns and csv files. I think this is due to being a PR from a fork. @rvhonorato can you assist? |
|
@sverhoeven, added a skip here #801 |
@sverhoeven looks perfect! let me know when it's ready and I'll review this! |
|
What should happen when there are more than 10 clusters? Almost ready, just need to make webapp use this PR and solve question above. |
first option! it would be in line with the 2.4 output https://bianca.science.uu.nl/haddock2.4/result/4242424242/0-E2A-HPR and, more importantly, would allow to directly inspect the best 4 structures that are not part of the top 10 clusters. This should be called "Other" rather than "-" I would say. would it be feasible to add a short disclaimer saying something like "This is not a real cluster but rather a combination of the top models of the other clusters"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plots look for the examples! I created this PR to uniform the names in capri folders #805 , maybe we can first merge that and then this one




You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:
toxtests pass. Runtoxcommand inside the repository folder-test.cfgexamples execute without errors. Insideexamples/runpython run_tests.py -bCloses #719
Uses Structures table from i-VRESSE/haddock3-analysis-components#13 to render when there are no clusters.