Skip to content

Conversation

@VGPReys
Copy link
Contributor

@VGPReys VGPReys commented Mar 26, 2024

You are about to submit a new Pull Request. Before continuing make sure you read the contributing guidelines and that you comply with the following criteria:

  • You have sticked to Python. Please talk to us before adding other programming languages to HADDOCK3
  • Your PR is about CNS
  • Your code is well documented: proper docstrings and explanatory comments for those tricky parts
  • You structured the code into small functions as much as possible. You can use classes if there is a (state) purpose
  • Your code follows our coding style
  • You wrote tests for the new code
  • tox tests pass. Run tox command inside the repository folder
  • -test.cfg examples execute without errors. Inside examples/ run python run_tests.py -b
  • PR does not add any dependencies, unless permission granted by the HADDOCK team
  • PR does not break licensing
  • Your PR is about writing documentation for already existing code 🔥
  • Your PR is about writing tests for already existing code :godmode:

Closes #836, by adding a new parameter allatoms in caprieval module.
By setting it to true, rmsd computation will be made on all heavy atoms.

@VGPReys VGPReys added enhancement Improving something in the codebase m|caprieval Improvements in caprieval module community Feature requests / contribution / issues from users labels Mar 26, 2024
@VGPReys VGPReys requested a review from mgiulini March 26, 2024 13:53
@VGPReys VGPReys self-assigned this Mar 26, 2024
Copy link
Contributor

@mgiulini mgiulini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but tests should be stricter in my opinion, especially about the coordinate loading..did you use another software to compare the all atoms results to the ones given by caprieval?

@VGPReys VGPReys requested a review from mgiulini April 26, 2024 13:04
Copy link
Contributor

@mgiulini mgiulini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks good, nice improvement!

@VGPReys VGPReys merged commit 9689d3c into main Apr 26, 2024
@VGPReys VGPReys deleted the allatm-caprieval branch April 26, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Feature requests / contribution / issues from users enhancement Improving something in the codebase m|caprieval Improvements in caprieval module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Heavy atoms or all atoms RMSD calculation in caprieval module

3 participants