Skip to content

Feature/upgrade rspec #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature/upgrade rspec #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1210d23
upgrade to latest rspec gems
adelevie Jun 14, 2014
5afb20c
stop using deprecated color_enabled in spec_helper
adelevie Jun 14, 2014
03b0a2c
Convert specs to RSpec 3.0.1 syntax with Transpec
adelevie Jun 14, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rails_nlp.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ Gem::Specification.new do |spec|

spec.add_development_dependency "bundler", "~> 1.6"
spec.add_development_dependency "rake"
spec.add_development_dependency "rspec-rails", '~> 2.14.1'
spec.add_development_dependency "rspec-rails", '~> 3.0.1'
spec.add_development_dependency "factory_girl_rails", "~> 4.0"
spec.add_development_dependency "guard", "~> 2.6"
spec.add_development_dependency "guard-rspec", "~> 4.2.8"
spec.add_development_dependency "guard-rspec", "~> 4.2.10"
spec.add_development_dependency "flexmock", "~> 1.3.1"
spec.add_development_dependency "shoulda-matchers", "~> 2.6.0"
spec.add_development_dependency "codeclimate-test-reporter"
Expand Down
6 changes: 3 additions & 3 deletions spec/rails_nlp/keyword_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

module RailsNlp
describe Keyword do
it { should validate_presence_of(:name)}
it { should validate_uniqueness_of(:name)}
it { should have_many(:wordcounts) }
it { is_expected.to validate_presence_of(:name)}
it { is_expected.to validate_uniqueness_of(:name)}
it { is_expected.to have_many(:wordcounts) }

describe "analysis of keywords before save" do
describe "phonetic" do
Expand Down
1 change: 0 additions & 1 deletion spec/spec_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

RSpec.configure do |config|
config.order = "random"
config.color_enabled = true
config.tty = true
config.mock_with :flexmock
config.include FactoryGirl::Syntax::Methods
Expand Down