Skip to content

Conversation

@rvcas
Copy link
Contributor

@rvcas rvcas commented May 5, 2017

Simply moved everything that is none elm to a new public folder. I had this idea when using create-alm-app and felt that it would be nice to keep the src folder pure elm.

closes: #123

@tbash
Copy link

tbash commented May 5, 2017

What would you think about moving the css, js, and that logo into their own dirs?
maybe something like:

  ▾ public/
    ▾ css/
        main.css
    ▾ js/
        index.js # or main.js
    ▾ media/
        logo.svg
    favicon.ico
    index.html
  ▸ src/
  ▸ test/
  .gitignore
  README.md
  elm-package.json

cc: @halfzebra

@rvcas
Copy link
Contributor Author

rvcas commented May 6, 2017

@tbash I like it

@halfzebra
Copy link
Owner

@lrosa007 sorry for the silence, I'll look into this PR shortly!

@rvcas
Copy link
Contributor Author

rvcas commented May 24, 2017

There are some conflicts, I'll rebase and fix that.

@halfzebra halfzebra force-pushed the master branch 5 times, most recently from d702b1d to f030951 Compare May 28, 2017 02:31
@fobos
Copy link
Contributor

fobos commented May 31, 2017

@lrosa007 could you please resolve conflicts one more time?

@rvcas
Copy link
Contributor Author

rvcas commented Jun 1, 2017

yes @fobos totally forgot to do it

@rvcas
Copy link
Contributor Author

rvcas commented Jun 1, 2017

ok @halfzebra & @fobos rebase is done

@halfzebra halfzebra mentioned this pull request Jun 1, 2017
3 tasks
@halfzebra
Copy link
Owner

halfzebra commented Jun 1, 2017

@lrosa007 thanks for the rebase, but unfortunately, we have to continue the discussion about the future structure in #135

Let's keep this PR on hold and merge it when we have a conclusion.

@rvcas
Copy link
Contributor Author

rvcas commented Jun 1, 2017

@halfzebra got it, thanks. 👍

@halfzebra
Copy link
Owner

@lrosa007 Thank you very much for your contribution!

This PR is partially merged in #138

Unfortunately, we can not accept all of the changes, made in this PR.

The reason why js/ and css/ folders are still in src/ is that public/ folder should serve as a folder for content, which is served outside the module system(i.e. not imported in index.js)

During ElmEurope 2017 we have been talking a lot about this specific PR and the options we could consider while reworking the template structure. @eeue56 have shared some experience about that, his opinion is that all the files inside the module system should be located in the same place.

For now, we will use public/ folder for static content, which is a highly demanded feature! 🙂

Thank you for initiating and participating in the discussion! 👍

#135 will be scoped down to smaller discussions, so we don't have to come up with the entire new structure.

Sorry for not accepting the entire list of changes, preserving the original semantics of public/ folder seems quite important at the moment.

@rvcas
Copy link
Contributor Author

rvcas commented Jun 14, 2017

@halfzebra Thanks 🎉

@rvcas rvcas closed this Jun 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move index.html/js into public folder

4 participants