-
Notifications
You must be signed in to change notification settings - Fork 147
Attempt to keep src folder pure elm #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
What would you think about moving the css, js, and that logo into their own dirs? cc: @halfzebra |
|
@tbash I like it |
|
@lrosa007 sorry for the silence, I'll look into this PR shortly! |
|
There are some conflicts, I'll rebase and fix that. |
d702b1d to
f030951
Compare
|
@lrosa007 could you please resolve conflicts one more time? |
|
yes @fobos totally forgot to do it |
|
ok @halfzebra & @fobos rebase is done |
|
@lrosa007 thanks for the rebase, but unfortunately, we have to continue the discussion about the future structure in #135 Let's keep this PR on hold and merge it when we have a conclusion. |
|
@halfzebra got it, thanks. 👍 |
|
@lrosa007 Thank you very much for your contribution! This PR is partially merged in #138 Unfortunately, we can not accept all of the changes, made in this PR. The reason why During ElmEurope 2017 we have been talking a lot about this specific PR and the options we could consider while reworking the template structure. @eeue56 have shared some experience about that, his opinion is that all the files inside the module system should be located in the same place. For now, we will use Thank you for initiating and participating in the discussion! 👍 #135 will be scoped down to smaller discussions, so we don't have to come up with the entire new structure. Sorry for not accepting the entire list of changes, preserving the original semantics of |
|
@halfzebra Thanks 🎉 |
Simply moved everything that is none elm to a new
publicfolder. I had this idea when usingcreate-alm-appand felt that it would be nice to keep thesrcfolder pure elm.closes: #123