feat($build): Added the support for PWA #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added SWPrecacheWebpackPlugin and a service worker to serve assets from local cache
Contributor
|
Seems like a good addition. One thing that would be nice to have - docs about how to opt-out - what files to remove, what code to delete. I believe they have it described in Create React App. It might be even better to have some automatic way to opt-out. The benefit would be that you can't mess up by forgetting to do some step. Not sure though how it would look like and how feasible it is. Just an idea. |
Owner
Author
|
@gyzerok thanks, I will add the docs and probably merge this 🙂 |
Contributor
|
Nice! I agree that having an opt out would be useful (for some quick apps I build I wouldn't care enough to want this) but love that we have this in! |
Contributor
|
Just have read the docs. Looks good. |
fobos
reviewed
Sep 12, 2017
| │ └── registerServiceWorker.js | ||
| └── tests | ||
| ├── Tests.elm | ||
| └── elm-package.json |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables us to deploy apps as Progressive Web Apps.
Added SWPrecacheWebpackPlugin and a service worker to serve assets from the local cache.
@fobos @gyzerok @jackfranklin got an opinion?
I just have been to the conference, and I think this is what we should support.
Here's an example of working PWA in Elm that I've made yesterday https://halfzebra.github.io/elm-scrum-cards-pwa/