Upgrade dependencies and introduce unexpectedjs #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fobos
approved these changes
Sep 13, 2017
| "rimraf": "^2.5.4", | ||
| "semantic-release": "^6.3.2" | ||
| "semantic-release": "^7.0.2", | ||
| "unexpected": "^10.35.0" |
Contributor
There was a problem hiding this comment.
For what reason you have changed chai to unexpected?
Owner
Author
There was a problem hiding this comment.
@fobos it produces more readable test errors, obviously, we don't have that many tests, so it's a little smaller as well.
I would roll back if you have a strong opinion on assertion lib. I've been doing a lot of testing with unexpected recently and I would say I've had a better time 🙂
Contributor
There was a problem hiding this comment.
Thanks for explanation.
I would roll back if you have a strong opinion on assertion lib.
It's ok to use unexpected. I see your points.
| "test": "npm run -s test:cli && npm run -s test:functional", | ||
| "test:cli": "mocha tests/cliAccessibility.js --reporter spec --timeout 15000", | ||
| "test:functional": "mocha tests/*.spec.js --reporter spec --timeout 15000" | ||
| "test": "npm run test:cli && npm run test:functional", |
Owner
Author
There was a problem hiding this comment.
That's clearly a mistake!
halfzebra
force-pushed
the
upgrade-dependencies-and-introduce-unexpectedjs
branch
2 times, most recently
from
a4eb3e0 to
dd22a50
Compare
halfzebra
force-pushed
the
upgrade-dependencies-and-introduce-unexpectedjs
branch
from
dd22a50 to
094920a
Compare
halfzebra
deleted the
upgrade-dependencies-and-introduce-unexpectedjs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171