Better error output #181
Merged
Better error output #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a function for stripping redundant text from error messages
fobos
reviewed
Sep 23, 2017
|
|
||
| module.exports = function formatElmCompilerErrors(messages) { | ||
| var errors = messages.errors; | ||
| var warnings = messages.warnings; |
Contributor
There was a problem hiding this comment.
Why not to use const and destructuring?
Owner
Author
There was a problem hiding this comment.
@fobos this one is supposed to be running in the browser and under the node(without being transpiled by Babel)
halfzebra
commented
Sep 25, 2017
| return errors.length > 0 | ||
| ? { | ||
| errors: errors | ||
| .map(x => |
Owner
Author
There was a problem hiding this comment.
I shouldn't be using arrow functions here because of browser compatibility issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.