fix: Makes it possible to enable the Elm debugger with ELM_DEBUGGER=true #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfzebra
requested changes
Sep 25, 2018
Owner
halfzebra
left a comment
halfzebra
left a comment
There was a problem hiding this comment.
Good job! 👍
It would be nice if you could address the comments, I'll release this asap.
config/webpack.config.prod.js
Outdated
| // for invalid values, "false" and as a default, disable it | ||
| debug: process.env.ELM_DEBUGGER === 'true' ? true : false, | ||
| optimize: true, | ||
| optimize: process.env.ELM_DEBUGGER === 'true' ? false : true, |
Owner
There was a problem hiding this comment.
Please move this into a variable, like in build.js
yarn.lock
Outdated
| @@ -0,0 +1,8766 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
Owner
There was a problem hiding this comment.
Please do not add this file to CVS
Contributor
Author
|
I've addressed the comments, thank you for good and quick feedback! |
halfzebra
approved these changes
Sep 25, 2018
Owner
|
Thanks for your contribution! |
runarfu
deleted the
issue-304-enable-debugger-with-flags-to-build-command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #304