fix(cli): Fix crash when installed via yarn #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`create-elm-app` crashed out-of-the-box after installing with `yarn global add create-elm-app`, at least on yarn 0.19.1. This was due to the fact that yarn had installed the `elm` package alongside `create-elm-app` rather than in the expected `create-elm-app/node_modules`. Fixes halfzebra#90
Owner
|
@adamdicarlo good job! 👍 I'll fix it asap and make a release. |
Contributor
Author
|
awesome! I hope the first time using commitizen... very cool. |
Contributor
Author
|
@halfzebra doesn't look like it's hit npm registry yet, could you give it a publish? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create-elm-appcrashed out-of-the-box after installing withyarn global add create-elm-app, at least on yarn 0.19.1. This was due to the fact that yarn had installed theelmpackage alongsidecreate-elm-apprather than in the expectedcreate-elm-app/node_modules.Fixes #90