Skip to content

Warn when variants in MAF file have wrong end position#115

Merged
iskandr merged 4 commits intomasterfrom
allow-maf-to-have-different-end-pos
Aug 3, 2015
Merged

Warn when variants in MAF file have wrong end position#115
iskandr merged 4 commits intomasterfrom
allow-maf-to-have-different-end-pos

Conversation

@iskandr
Copy link
Copy Markdown
Contributor

@iskandr iskandr commented Aug 2, 2015

Some MAFs in the wild seem to have end positions which violate what's expected with base-1 inclusive coordinates, so warn about unexpected end positions instead of raising an exception. (fixes #105)

Review on Reviewable

@tavinathanson
Copy link
Copy Markdown
Contributor

Hmm. Do we really never want to ValueError here? What if we warn only in a specific off-by-one case, and ValueError otherwise?

@iskandr
Copy link
Copy Markdown
Contributor Author

iskandr commented Aug 2, 2015

@tavinathanson I thought about trying to figure out what a safe category of errors is, but...what if our normalization of the ref/alt sequences makes the "safe" error range greater than 1?

@tavinathanson
Copy link
Copy Markdown
Contributor

Thinking more about this: I feel like this still is saying more about the wonkiness of the MAF file than anything else, and the user probably should know that their MAF file is weird.

What about ValueError by default, unless the user loads the MAF as follows: variants = varcode.load_maf("tcga-ovarian-cancer-variants.maf", validate_maf=False)?

@tavinathanson
Copy link
Copy Markdown
Contributor

Ah, but that would need to be annoyingly passed through from Topiary, given Kipp's use case.

Eh. Bleh. Feel free to just merge.

iskandr added a commit that referenced this pull request Aug 3, 2015
…d-pos

Warn when variants in MAF file have wrong end position
@iskandr iskandr merged commit 2826f4d into master Aug 3, 2015
@iskandr iskandr deleted the allow-maf-to-have-different-end-pos branch August 3, 2015 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double mutations in a MAF file cause error

2 participants