Conversation
…nt sequences for comparison
Contributor
There was a problem hiding this comment.
Sadly, we lost xrange in Py3, do you mind changing this to six.moves.range?
Contributor
|
Thanks for catching this. Aside from making sure it works with Python 3, do you mind adding the example variants to |
Python 2/3 compatibility
Called Silent but should be PrematureStop 7 117182143 . T TGTA . . . GT 0/1 Called Deletion but should be PrematureStop 7 117182143 . TAACAG TATAAC . . . GT 0/1 Called Insertion but should be PrematureStop 7 117182143 . TA TATAGGTT . . . GT 0/1
Contributor
Author
|
Ok, added! Thanks for the catch with compatibility. |
iskandr
added a commit
that referenced
this pull request
Aug 21, 2015
Fix #116 and call PrematureStop when stop codon is added in the middle of an insertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #116. Also ran into an issue that if a stop codon is not at the end of an in-frame coding variant, it will not get called a PrematureStop. I seems like it still should though, so I changed that too.
Here are three examples that were not called as PrematureStop before but are now.
Called Silent but should be PrematureStop
7 117182143 . T TGTA . . . GT 0/1Called Deletion but should be PrematureStop
7 117182143 . TAACAG TATAAC . . . GT 0/1Called Insertion but should be PrematureStop
7 117182143 . TA TATAGGTT . . . GT 0/1