Quotes around nucleotides in Variant representation#139
Merged
Conversation
| self.start, | ||
| self.ref if self.ref else ".", | ||
| self.alt if self.alt else ".", | ||
| self.ref, |
Contributor
There was a problem hiding this comment.
does this need to check for ref or alt being None or does that never happen?
Contributor
Author
There was a problem hiding this comment.
We check the length of both alt and ref in the initializer so I don't think it's possible for them to be None in a constructed Variant.
Contributor
|
LGTM, one question on whether the alt/ref should still be explicitly set as empty string |
iskandr
added a commit
that referenced
this pull request
Mar 15, 2016
Quotes around nucleotides in Variant representation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of representing empty strings with
., instead using single quotes around all string fields of aVariant. This brings us closer to having a string representation of a variant which can be evaluated by Python to get back to the same object (the reference name isn't quite there).Also, got rid of
Variant.preserves_reading_framesince I've come around to @arahuja's opinion that this is a confusing property.This change is