Merged
Conversation
Contributor
iskandr
commented
Mar 24, 2015
iskandr
commented
Contributor
There was a problem hiding this comment.
How about info on filing, PRs, etc. ala https://github.com/hammerlab/guacamole/blob/master/CONTRIBUTING.md?
Contributor
|
Is this PR supposed to have code changes too? |
Contributor
Author
|
The code changes are because this branch is off another than Tim is reviewing, I'll rebase it once that other branch is done. |
iskandr
force-pushed
the
add-contributing-md
branch
from
d785b77 to
5d35184
Compare
Contributor
|
👍 |
Contributor
|
Merge away when ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.