Skip to content

Created EpitopeCollection, refactored effects#65

Merged
iskandr merged 7 commits intomasterfrom
epitope-collection
Apr 24, 2015
Merged

Created EpitopeCollection, refactored effects#65
iskandr merged 7 commits intomasterfrom
epitope-collection

Conversation

@iskandr
Copy link
Copy Markdown
Contributor

@iskandr iskandr commented Apr 23, 2015

  • Created an EffectCollection, which is used for filtering and grouping sets of effects.
  • VariantCollection.effects() now returns an EffectCollection.
  • Merged functionality of top_effect() and highest_priority_effects into EffectCollection.top_priority_effect()
  • Created a base class Collection from which VariantCollection and EffectCollection get their simpler methods like __iter__ and __len__
  • Simplified the effect hierarchy, expanded the ambiguous aa_pos (which means slightly different things for different effect types), into the more explicit aa_mutation_start_offset and aa_mutation_end_offset.

Fixes #64 and #58.

Review on Reviewable

@iskandr iskandr merged commit 41b46c5 into master Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modifies_coding_sequence is always false

2 participants