Skip to content

Filter effect collection by expression#67

Merged
iskandr merged 8 commits intomasterfrom
filter-effect-collection-by-expression
Apr 27, 2015
Merged

Filter effect collection by expression#67
iskandr merged 8 commits intomasterfrom
filter-effect-collection-by-expression

Conversation

@iskandr
Copy link
Copy Markdown
Contributor

@iskandr iskandr commented Apr 25, 2015

  • added filter_transcript_expression and filter_gene_expression methods to EffectCollection
  • fixed summary_string on EffectCollection
  • renamed summary_string -> detailed_string
  • changed str method to print collection elements
  • added a short_string method which doesn't print collection elements
  • added unit tests for common Collection methods

Review on Reviewable

…ctCollection, fixed summary_string in EffectCollection, renamed summary_string->to_string, added common show() method to both collection classes
Comment thread varcode/collection.py Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.elements?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

iskandr added a commit that referenced this pull request Apr 27, 2015
…ression

Filter effect collection by expression
@iskandr iskandr merged commit 0d09090 into master Apr 27, 2015
@iskandr iskandr deleted the filter-effect-collection-by-expression branch April 27, 2015 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants