Skip to content

Use find_packages correctly#85

Merged
arahuja merged 1 commit intomasterfrom
find_packages_fix
May 26, 2015
Merged

Use find_packages correctly#85
arahuja merged 1 commit intomasterfrom
find_packages_fix

Conversation

@tavinathanson
Copy link
Copy Markdown
Contributor

@tavinathanson tavinathanson commented May 23, 2015

Fixes #84

find_packages appears to either take an exclusion list or no args, rather than just "test". With no args, it does include both varcode and test, as evidenced by the top_level.txt:

test
varcode

Before this fix, top_level.txt is empty and import varcode doesn't work.

Review on Reviewable

@hammer
Copy link
Copy Markdown

hammer commented May 25, 2015

Works for me!

arahuja added a commit that referenced this pull request May 26, 2015
@arahuja
Merge pull request #85 from hammerlab/find_packages_fix
3a9b9b7 
Use find_packages correctly
@arahuja arahuja merged commit 3a9b9b7 into master May 26, 2015
@arahuja arahuja deleted the find_packages_fix branch May 26, 2015 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pip installing Varcode doesn't seem to work lately

3 participants

@tavinathanson @hammer @arahuja