Fix supervisor messages about exited services. #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimCitus
added
bug
JelteF
approved these changes
Feb 23, 2021
Comment on lines
+644
to
647
| else if (WIFEXITED(status) && WEXITSTATUS(status) == EXIT_CODE_QUIT) | ||
| { | ||
| logLevel = LOG_WARN; | ||
| } |
There was a problem hiding this comment.
nit: this could be moved in the WIFEXITED branch below
The waitpid() reading of the conditions that lead to a process being reported are more complex than the previous implementation assumed.
DimCitus
force-pushed
the
fix/supervisor-waitpid-diagnostic
branch
from
2928f19 to
b872c25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The waitpid() reading of the conditions that lead to a process being
reported are more complex than the previous implementation assumed.