Skip to content

Fix a buffer overlap instruction that macOs libc fails to process. #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2021
Merged

Fix a buffer overlap instruction that macOs libc fails to process. #610

merged 2 commits into from
Mar 3, 2021

Conversation

@DimCitus
Copy link
Collaborator

@DimCitus DimCitus commented Mar 3, 2021

No description provided.

@DimCitus DimCitus added the bug Something isn't working label Mar 3, 2021
@DimCitus DimCitus added this to the Sprint 2021 W9 W10 milestone Mar 3, 2021
@DimCitus DimCitus requested a review from JelteF March 3, 2021 14:48
@DimCitus DimCitus self-assigned this Mar 3, 2021
JelteF
JelteF approved these changes Mar 3, 2021
View reviewed changes
Copy link
Contributor

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I understand this change fixes a strlcpy in standby_init_replication_source
where src and dst are the same (or at least overlapping). If that's indeed correct I think it's good to merge.

@DimCitus
Copy link
Collaborator Author

DimCitus commented Mar 3, 2021

Indeed the problem is that we had a strlcpy call using same src and dst address. I could have made it obvious, sorry...

@DimCitus DimCitus merged commit d0a4f1c into master Mar 3, 2021
@DimCitus DimCitus deleted the fix/illegal-instruction-buffer-overlap branch March 3, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JelteF JelteF JelteF approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DimCitus DimCitus

Labels

bug Something isn't working

Projects

None yet

Milestone

Sprint 2021 W9 W10

Development

Successfully merging this pull request may close these issues.

3 participants

@DimCitus @JelteF