Skip to content

Conversation

@DimCitus
Copy link
Collaborator

@DimCitus DimCitus commented May 5, 2021

The formation context parts should also be an array, even when we know it
contains a single element for now.

Fixes #694

@DimCitus DimCitus added bug Something isn't working Size: S Effort Estimate: Small labels May 5, 2021
@DimCitus DimCitus added this to the Sprint 2021 W18 W19 milestone May 5, 2021
@DimCitus DimCitus requested a review from JelteF May 5, 2021 10:07
@DimCitus DimCitus self-assigned this May 5, 2021
@DimCitus
Copy link
Collaborator Author

DimCitus commented May 5, 2021

With this fix we have:

$ pg_autoctl show settings --json | jq '.formation'
[
  {
    "value": "1",
    "context": "formation",
    "node_id": null,
    "setting": "number_sync_standbys",
    "group_id": null,
    "nodename": "default"
  }
]

And that makes sense, and it's the same format as the other parameters, using JSON objects in an EAV approach.

Copy link
Contributor

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Needs to be called out as a breaking change in the changelog though.

The formation context parts should also be an array, even when we know it
contains a single element for now.
@DimCitus DimCitus force-pushed the fix/formation-settings-in-json branch from a68b2f5 to 595b3c2 Compare May 5, 2021 13:31
@DimCitus DimCitus merged commit e7e33bc into master May 5, 2021
@DimCitus DimCitus deleted the fix/formation-settings-in-json branch May 5, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Size: S Effort Estimate: Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

formation settings 'formations' property should be an array or a non-generic object

3 participants