-
Notifications
You must be signed in to change notification settings - Fork 129
Include Postgres 15 in our CI testing. #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The citusdata tooling most recent tag is now v0.8.18, so let's try that one.
|
Tools repo is not yet updated for PG15 support for the scripts that are used to install Postgresql beta packages for PG15. Let me update this PR once the tools repo is ready. |
| run: | | ||
| gcc --version | ||
| git clone -b v0.7.22 --depth 1 https://github.com/citusdata/tools.git ../tools | ||
| git clone -b add-pg15-scripts --depth 1 https://github.com/citusdata/tools.git ../tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once citusdata/tools#239 lands, we will create and push a tag on tools repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any news about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pinged @gurkanindibay who worked on CI readiness for PG15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-run the tests, and apparently we are missing some packages for zstd that breaks our builds on PG15 now.
https://github.com/citusdata/pg_auto_failover/actions/runs/3150979932
I do not have much bandwidth, but I guess @gurkanindibay will update this PR by:
a) updating the Pre Install Steps in this file to install missing packages
b) update the tools tag to latest available version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we still need the special branch add-pg15-scripts of the tools repository, rather than the current/latest tagged version of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for fixing it @gurkanindibay ; can you approve the Pull Request so that I can then merge it? thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finally bypassed the rule for extra approval.
|
PG 15.0 is just around the corner, any chances to have a pg_auto_failover release with PG15 support before that? |
|
Fixes #934. |
|
Any updates? |
Well the “main” branch is now compatible with Postgres 15, and the CI includes Postgres 11, 12, 13, 14, and 15 now. I have to go through issues and show-stoppers before the next release, which should happen either next week or the week after that I believe. |
The citusdata tooling most recent tag is now v0.8.18, so let's try that one.