Skip to content

Conversation

@DimCitus
Copy link
Collaborator

The citusdata tooling most recent tag is now v0.8.18, so let's try that one.

DimCitus and others added 2 commits August 18, 2022 15:33
The citusdata tooling most recent tag is now v0.8.18, so let's try that one.
@hanefi
Copy link
Contributor

hanefi commented Aug 18, 2022

Tools repo is not yet updated for PG15 support for the scripts that are used to install Postgresql beta packages for PG15. Let me update this PR once the tools repo is ready.

run: |
gcc --version
git clone -b v0.7.22 --depth 1 https://github.com/citusdata/tools.git ../tools
git clone -b add-pg15-scripts --depth 1 https://github.com/citusdata/tools.git ../tools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once citusdata/tools#239 lands, we will create and push a tag on tools repo.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any news about that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pinged @gurkanindibay who worked on CI readiness for PG15.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-run the tests, and apparently we are missing some packages for zstd that breaks our builds on PG15 now.

https://github.com/citusdata/pg_auto_failover/actions/runs/3150979932

I do not have much bandwidth, but I guess @gurkanindibay will update this PR by:
a) updating the Pre Install Steps in this file to install missing packages
b) update the tools tag to latest available version.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we still need the special branch add-pg15-scripts of the tools repository, rather than the current/latest tagged version of it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hanefi @DimCitus Build is successful now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing it @gurkanindibay ; can you approve the Pull Request so that I can then merge it? thanks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally bypassed the rule for extra approval.

@df7cb
Copy link
Contributor

df7cb commented Sep 28, 2022

PG 15.0 is just around the corner, any chances to have a pg_auto_failover release with PG15 support before that?

@DimCitus DimCitus mentioned this pull request Sep 29, 2022
@DimCitus
Copy link
Collaborator Author

Fixes #934.

@DimCitus DimCitus merged commit eb71998 into master Sep 29, 2022
@DimCitus DimCitus deleted the ci/include-pg-15 branch September 29, 2022 16:46
@devrimgunduz
Copy link

Any updates?

@DimCitus
Copy link
Collaborator Author

DimCitus commented Oct 6, 2022

Any updates?

Well the “main” branch is now compatible with Postgres 15, and the CI includes Postgres 11, 12, 13, 14, and 15 now. I have to go through issues and show-stoppers before the next release, which should happen either next week or the week after that I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants