fix: conversion for port number#1309
Merged
zariiii9003 merged 9 commits intohardbyte:developfrom Aug 12, 2022
Merged
Conversation
hardbyte
approved these changes
Jun 5, 2022
hardbyte
reviewed
Jun 5, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1309 +/- ##
===========================================
- Coverage 66.24% 66.18% -0.07%
===========================================
Files 86 86
Lines 9009 9019 +10
===========================================
+ Hits 5968 5969 +1
- Misses 3041 3050 +9 |
Contributor
Author
|
I would need some help in figuring out how to fix mypy error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If reading the port number (for remote can) from a config file, the dict contains a string, that crashes becouse it require an integer.