Fix decoding error in Kvaser constructor for non-ASCII product name#1613
Merged
zariiii9003 merged 3 commits intohardbyte:developfrom Jun 13, 2023
Merged
Fix decoding error in Kvaser constructor for non-ASCII product name#1613zariiii9003 merged 3 commits intohardbyte:developfrom
zariiii9003 merged 3 commits intohardbyte:developfrom
Conversation
Previously, illegal characters triggered an exception. With the new behavior, illegal characters will be replaced with a placeholder value.
lumagi
force-pushed
the
fix/kvaser_channel_charset
branch
from
40ced11 to
d3de662
Compare
lumagi
changed the title
Collaborator
|
@lumagi do you have a Kvaser interface for testing? |
Collaborator
Author
|
Unfortunately, no. All I can offer is PEAK, ETAS, or Vector. |
zariiii9003
approved these changes
Jun 13, 2023
Collaborator
zariiii9003
left a comment
zariiii9003
left a comment
There was a problem hiding this comment.
Looks good, thank you :)
zariiii9003
pushed a commit
to zariiii9003/python-can
that referenced
this pull request
Jun 18, 2023
…ardbyte#1613) * Implement test to trigger ASCII decoding error in Kvaser bus constructor * Change handling of invalid chars in Kvaser device name Previously, illegal characters triggered an exception. With the new behavior, illegal characters will be replaced with a placeholder value. * Rename variables in test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR will change the constructor to be less susceptible to non-ASCII characters in the device description.